-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WSTEAMA-1382 Remove media player component, and add MediaLoader instead to OD Audio and Podcast pages #11998
Merged
eagerterrier
merged 70 commits into
latest
from
WSTEAMA-1382-remove-media-player-component-and-add-mediaLoaders
Sep 30, 2024
Merged
WSTEAMA-1382 Remove media player component, and add MediaLoader instead to OD Audio and Podcast pages #11998
eagerterrier
merged 70 commits into
latest
from
WSTEAMA-1382-remove-media-player-component-and-add-mediaLoaders
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nabeel1276
changed the title
Wsteama 1382 remove media player component and add media loaders
WSTEAMA-1382 remove media player component and add media loaders
Sep 23, 2024
…-and-add-mediaLoaders
holchris
changed the base branch from
latest
to
WSTEAMA-1322-generate-smp-settings-object-for-on-demand-audio-&-add-tests
September 23, 2024 10:36
holchris
changed the title
WSTEAMA-1382 remove media player component and add media loaders
WSTEAMA-1382 Remove media player component, and add MediaLoader instead to OD Audio and Podcast pages
Sep 23, 2024
Base automatically changed from
WSTEAMA-1322-generate-smp-settings-object-for-on-demand-audio-&-add-tests
to
latest
September 23, 2024 14:48
…aLoaders' of https://github.com/bbc/simorgh into WSTEAMA-1382-remove-media-player-component-and-add-mediaLoaders
…-and-add-mediaLoaders
…aLoaders' of https://github.com/bbc/simorgh into WSTEAMA-1382-remove-media-player-component-and-add-mediaLoaders
…aLoaders' of https://github.com/bbc/simorgh into WSTEAMA-1382-remove-media-player-component-and-add-mediaLoaders
…-and-add-mediaLoaders
…-and-add-mediaLoaders
…aLoaders' of https://github.com/bbc/simorgh into WSTEAMA-1382-remove-media-player-component-and-add-mediaLoaders
alex-magana
force-pushed
the
WSTEAMA-1382-remove-media-player-component-and-add-mediaLoaders
branch
from
September 27, 2024 14:15
f731f68
to
302a6ba
Compare
…-and-add-mediaLoaders
…aLoaders' of https://github.com/bbc/simorgh into WSTEAMA-1382-remove-media-player-component-and-add-mediaLoaders
Co-authored-by: Karina Thomas <58214768+karinathomasbbc@users.noreply.github.com>
karinathomasbbc
approved these changes
Sep 30, 2024
eagerterrier
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…-and-add-mediaLoaders
…-and-add-mediaLoaders
eagerterrier
deleted the
WSTEAMA-1382-remove-media-player-component-and-add-mediaLoaders
branch
September 30, 2024 14:16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA 1382
Overall changes
Replaces AVPlayer with MediaLoader
Code changes
Testing
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines